Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward context in toolchain-common pkg/client #502

Merged

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Nov 9, 2023

Requiring toolchain-common#340 and member-operator#501

Signed-off-by: Francesco Ilario filario@redhat.com

Signed-off-by: Francesco Ilario <filario@redhat.com>
Copy link

openshift-ci bot commented Nov 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #502 (c7236fc) into master (082aed8) will increase coverage by 0.01%.
The diff coverage is 89.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   82.46%   82.48%   +0.01%     
==========================================
  Files          29       29              
  Lines        3188     3191       +3     
==========================================
+ Hits         2629     2632       +3     
  Misses        424      424              
  Partials      135      135              
Files Coverage Δ
controllers/memberstatus/creation.go 100.00% <100.00%> (ø)
controllers/nstemplateset/client.go 81.63% <100.00%> (ø)
pkg/autoscaler/autoscaler.go 73.91% <100.00%> (ø)
pkg/consoleplugin/deploy/deployment.go 66.66% <100.00%> (ø)
...roperatorconfig/memberoperatorconfig_controller.go 79.16% <85.71%> (+0.59%) ⬆️
controllers/nstemplateset/cluster_resources.go 83.56% <91.66%> (+0.07%) ⬆️
pkg/webhook/deploy/deployment.go 62.50% <0.00%> (ø)

Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

Copy link

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov alexeykazakov merged commit 8c0146d into codeready-toolchain:master Nov 20, 2023
11 checks passed
@filariow filariow deleted the context-common-client branch November 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants