update api & test changes in e2e setup #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
mfrancisc
approved these changes
Mar 1, 2024
metlos
approved these changes
Mar 1, 2024
rajivnathan
approved these changes
Mar 1, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 29 29
Lines 3281 3281
=======================================
Hits 2715 2715
Misses 423 423
Partials 143 143 |
alexeykazakov
approved these changes
Mar 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, metlos, mfrancisc, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alexeykazakov
merged commit 0bc5475
into
codeready-toolchain:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to test changes in codeready-toolchain/toolchain-e2e#907 so while doing that I decided to update api & toolchain-common dependencies so I have some meaningful changes in the PR :-)
The dependency updates doesn't relate to the changes in toolchain-e2e anyhow.