cache ToolchainCluster CR only in the given namespace #587
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 31 31
Lines 2704 2704
=======================================
Hits 2253 2253
Misses 304 304
Partials 147 147 |
go.sum
Outdated
| github.com/MatousJobanek/toolchain-common v0.0.0-20240726063305-474ff3c9f3fd h1:EG5doMCpbKhduGK9olCq/Bzn+cC9YcWGzu0+Z0roKT0= | ||
| github.com/MatousJobanek/toolchain-common v0.0.0-20240726063305-474ff3c9f3fd/go.mod h1:LGk4lAYtvYPXgopPW65aoa7c5KiKq6Ssuytgckc31Wk= |
There was a problem hiding this comment.
This doesn't look right. Why you have references to MatousJobanek repo here?
Make sure you did go mod tidy.
There was a problem hiding this comment.
i am not sure why this happened .. but removed it.
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexeykazakov, fbm3307, rajivnathan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
@fbm3307: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
It looks like that there is no change in this PR anymore as the toolchain-common dependency was updated via another PR that is already merged. |
This is related to codeready-toolchain/toolchain-common#419
it just a dependency check