remove webConsolePlugin from ToolchainClusterConfig (phase 2) #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcoulon
requested review from
MatousJobanek,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Pendo has been decommisioned, we don't need this plugin anymore Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
xcoulon
force-pushed
the
remove_pendo_member
branch
from
c0a23a3 to
6ba16ce
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 83.32% 83.56% +0.24%
==========================================
Files 31 28 -3
Lines 2704 2592 -112
==========================================
- Hits 2253 2166 -87
+ Misses 304 287 -17
+ Partials 147 139 -8
|
There was a problem hiding this comment.
- Please create a separate PR for the CRD update. See remove webConsolePlugin from ToolchainClusterConfig host-operator#1068 (comment) for details.
- We also need to delete https://github.com/codeready-toolchain/member-operator/tree/master/webconsole_source
- And please clean up the make files (make generates plugin JS from the webconsole TS source a mentioned above)
xcoulon
changed the title
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
alexeykazakov
approved these changes
Aug 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, xcoulon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pendo has been decommisioned, we don't need this plugin anymore
see also:
Signed-off-by: Xavier Coulon xcoulon@redhat.com