Set CPU limit and request for Autoscaler Buffer when deploying it #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykazakov
requested review from
MatousJobanek,
xcoulon,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced Aug 5, 2024
MatousJobanek
approved these changes
Aug 6, 2024
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
==========================================
- Coverage 83.56% 83.56% -0.01%
==========================================
Files 28 28
Lines 2592 2604 +12
==========================================
+ Hits 2166 2176 +10
- Misses 287 288 +1
- Partials 139 140 +1
|
alexeykazakov
merged commit a0cdbff
into
codeready-toolchain:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes the CPU settings from the member operator configuration.
Part of https://issues.redhat.com/browse/SANDBOX-659
Requires codeready-toolchain/host-operator#1071
Paired with codeready-toolchain/toolchain-e2e#1027