KUBESAW-250: Updating GolangCiLint to v1.63.1

.github/workflows/ci-golang-sbom.yml

@@ -29,7 +29,7 @@ jobs:
     - name: Lint
       uses: golangci/golangci-lint-action@v6
       with:
-        version: v1.56.2
+        version: v1.63.1
         skip-pkg-cache: true
         skip-build-cache: true
         args: --config=./.golangci.yml --verbose

controllers/memberstatus/memberstatus_controller_test.go

@@ -74,7 +74,7 @@ func TestNoMemberStatusFound(t *testing.T) {
 		getHostClusterFunc := newGetHostClusterReady
 		reconciler, req, fakeClient := prepareReconcile(t, requestName, getHostClusterFunc, allNamespacesCl, mockLastGitHubAPICall, defaultGitHubClient)
 		fakeClient.MockGet = func(ctx context.Context, key types.NamespacedName, obj client.Object, opts ...client.GetOption) error {
-			return fmt.Errorf(expectedErrMsg)
+			return fmt.Errorf("%s", expectedErrMsg)
 		}
 
 		// when

controllers/nstemplateset/space_roles.go

@@ -3,7 +3,6 @@
 import (
 	"context"
 	"encoding/json"
-	"fmt"
 	"reflect"
 
 	toolchainv1alpha1 "github.com/codeready-toolchain/api/api/v1alpha1"
@@ -79,15 +78,15 @@
 			sr, err := json.Marshal(nsTmplSet.Spec.SpaceRoles)
 			if err != nil {
 				return false, r.wrapErrorWithStatusUpdate(lctx, nsTmplSet, r.setStatusProvisionFailed, err,
-					fmt.Sprintf("failed to marshal space roles to update '%s' annotation on namespace", toolchainv1alpha1.LastAppliedSpaceRolesAnnotationKey))
+					"failed to marshal space roles to update '%s' annotation on namespace", toolchainv1alpha1.LastAppliedSpaceRolesAnnotationKey)
 			}
 			if ns.Annotations == nil {
 				ns.Annotations = map[string]string{}
 			}
 			ns.Annotations[toolchainv1alpha1.LastAppliedSpaceRolesAnnotationKey] = string(sr)
 			if err := r.Client.Update(ctx, &ns); err != nil {
 				return false, r.wrapErrorWithStatusUpdate(lctx, nsTmplSet, r.setStatusProvisionFailed, err,
-					fmt.Sprintf("failed to update namespace with '%s' annotation", toolchainv1alpha1.LastAppliedSpaceRolesAnnotationKey))
+					"failed to update namespace with '%s' annotation", toolchainv1alpha1.LastAppliedSpaceRolesAnnotationKey)
 			}
 			logger.Info("updated annotation on namespace", toolchainv1alpha1.LastAppliedSpaceRolesAnnotationKey, string(sr))
 			return true, nil

pkg/webhook/mutatingwebhook/mutate.go

@@ -63,7 +63,7 @@ func handleMutate(logger logr.Logger, w http.ResponseWriter, r *http.Request, mu
 
 func writeResponse(logger logr.Logger, responseCode int, w http.ResponseWriter, respBody []byte) {
 	w.WriteHeader(responseCode)
-	if _, err := io.WriteString(w, string(respBody)); err != nil {
+	if _, err := io.Writer.Write(w, respBody); err != nil { //using 'io.Writer.Write' as per the static check SA6006: use io.Writer.Write instead of converting from []byte to string to use io.WriteString (staticcheck)
 		logger.Error(err, "unable to write adm review response")
 	}
 }

pkg/webhook/validatingwebhook/validate_rolebinding_request.go

@@ -40,7 +40,7 @@ func (v RoleBindingRequestValidator) HandleValidate(w http.ResponseWriter, r *ht
 		respBody = v.validate(r.Context(), body)
 		w.WriteHeader(http.StatusOK)
 	}
-	if _, err := io.WriteString(w, string(respBody)); err != nil {
+	if _, err := io.Writer.Write(w, respBody); err != nil { //using 'io.Writer.Write' as per the static check SA6006: use io.Writer.Write instead of converting from []byte to string to use io.WriteString (staticcheck)
 		log.Error(err, "unable to write response")
 	}
 }

pkg/webhook/validatingwebhook/validate_spacebindingrequest.go

@@ -42,7 +42,7 @@
 		respBody = v.validate(r.Context(), body)
 		w.WriteHeader(http.StatusOK)
 	}
-	if _, err := io.WriteString(w, string(respBody)); err != nil {
+	if _, err := io.Writer.Write(w, respBody); err != nil { //using 'io.Writer.Write' as per the static check SA6006: use io.Writer.Write instead of converting from []byte to string to use io.WriteString (staticcheck)
 		log.Error(err, "unable to write response")
 	}
 }

pkg/webhook/validatingwebhook/validate_ssp_request.go

@@ -37,7 +37,7 @@ func (v SSPRequestValidator) HandleValidate(w http.ResponseWriter, r *http.Reque
 		respBody = v.validate(r.Context(), body)
 		w.WriteHeader(http.StatusOK)
 	}
-	if _, err := io.WriteString(w, string(respBody)); err != nil {
+	if _, err := io.Writer.Write(w, respBody); err != nil { //using 'io.Writer.Write' as per the static check SA6006: use io.Writer.Write instead of converting from []byte to string to use io.WriteString (staticcheck)
 		log.Error(err, "unable to write response")
 	}
 }

pkg/webhook/validatingwebhook/validate_vm_request.go

@@ -32,7 +32,7 @@ func (v VMRequestValidator) HandleValidate(w http.ResponseWriter, r *http.Reques
 		respBody = v.validate(body)
 		w.WriteHeader(http.StatusOK)
 	}
-	if _, err := io.WriteString(w, string(respBody)); err != nil {
+	if _, err := io.Writer.Write(w, respBody); err != nil { //using 'io.Writer.Write' as per the static check SA6006: use io.Writer.Write instead of converting from []byte to string to use io.WriteString (staticcheck)
 		log.Error(err, "unable to write response")
 	}
 }