Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: binding request field should not be returned when empty #358

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix: binding request field should not be returned when empty #358

merged 2 commits into from
Oct 13, 2023

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc mentioned this pull request Oct 12, 2023
Merged
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
pkg/proxy/handlers/spacelister.go 91.07% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
80.0% 80.0% Duplication

@mfrancisc mfrancisc merged commit 14312cb into codeready-toolchain:master Oct 13, 2023
10 checks passed
@mfrancisc mfrancisc deleted the fixbindingrequest branch October 13, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajivnathan rajivnathan rajivnathan approved these changes

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@sbryzak sbryzak Awaiting requested review from sbryzak

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfrancisc @alexeykazakov @MatousJobanek @rajivnathan