add PublicViewer's middleware #453
Conversation
this commit is part of the effort of splitting codeready-toolchain#443 Signed-off-by: Francesco Ilario <filario@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: filariow The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 78.56% 78.60% +0.04%
==========================================
Files 42 42
Lines 2696 2702 +6
==========================================
+ Hits 2118 2124 +6
Misses 487 487
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
These changes enable support for public-viewer in public staging even if the feature is not completely merged in KubeSaw. This will avoid the loop in which KubeSaw host-operator deletes the SpaceBinding for the Public-Viewer user and the Konflux-Workspaces operator is creating it back. RegistrationService is not going to be impacted by this change until codeready-toolchain/registration-service#453 merges. Signed-off-by: Francesco Ilario <filario@redhat.com>
These changes enable support for public-viewer in public staging even if the feature is not completely merged in KubeSaw. This will avoid the loop in which KubeSaw host-operator deletes the SpaceBinding for the Public-Viewer user and the Konflux-Workspaces operator is creating it back. RegistrationService is not going to be impacted by this change until codeready-toolchain/registration-service#453 merges. Signed-off-by: Francesco Ilario <filario@redhat.com>
|
superseded by #443 |
This PR is part of the effort of splitting #443.
This PR introduces the logic to effectively turn on the PublicViewer support and for this reason it should be the latest PR to merge.
Requirements:
Signed-off-by: Francesco Ilario filario@redhat.com