Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use UTC time in tests #444

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

filariow
Copy link
Contributor

No description provided.

Signed-off-by: Francesco Ilario <filario@redhat.com>
Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there something that prompted this change?

@filariow
Copy link
Contributor Author

Was there something that prompted this change?

I was not able to understand the reason why, but these tests started failing on my local with both go 1.20.8 and 1.22.2.

@rajivnathan
Copy link
Contributor

I was not able to understand the reason why, but these tests started failing on my local with both go 1.20.8 and 1.22.2.

That's interesting, I just tried without your changes and it's failing for me too. I verified your change resolves it but it would be good to understand why. It looks like it could be related to #432 cc @sbryzak

@filariow
Copy link
Contributor Author

I think the main reason why we didn't notice this before merging #432 is that the CI instances are running with timezone set to UTC.

Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks like this was probably just missed from the original PR. I think the fix is good 👍

Copy link

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (2d147e4) to head (1cfcd94).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          41       41           
  Lines        2681     2681           
=======================================
  Hits         2095     2095           
  Misses        491      491           
  Partials       95       95           
Flag Coverage Δ
unittests 78.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajivnathan rajivnathan merged commit 912a3fd into codeready-toolchain:master Jul 12, 2024
9 of 10 checks passed
@filariow filariow deleted the fix-utc-tests branch July 13, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants