-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use UTC time in tests #444
fix: use UTC time in tests #444
Conversation
Signed-off-by: Francesco Ilario <filario@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there something that prompted this change?
I was not able to understand the reason why, but these tests started failing on my local with both |
That's interesting, I just tried without your changes and it's failing for me too. I verified your change resolves it but it would be good to understand why. It looks like it could be related to #432 cc @sbryzak |
I think the main reason why we didn't notice this before merging #432 is that the CI instances are running with timezone set to UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok looks like this was probably just missed from the original PR. I think the fix is good 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filariow, rajivnathan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 41 41
Lines 2681 2681
=======================================
Hits 2095 2095
Misses 491 491
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
912a3fd
into
codeready-toolchain:master
No description provided.