Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add public-viewer support to SpaceLister's List #452

Merged
merged 14 commits into from
Aug 26, 2024
Merged

add public-viewer support to SpaceLister's List #452

merged 14 commits into from
Aug 26, 2024

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Jul 25, 2024 •
edited
Loading

This PR is part of the effort of splitting PR #443

Requires the following PRs to be merged

filariow added 3 commits July 25, 2024 14:10
@filariow
add public-viewer support to pkg/configuration
414cf41 
this commit is part of PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
add public-viewer support to pkg/context
06efa59 
this commit is part of PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
add public-viewer support to SpaceLister's List
511ea82 
this commit is part of the effort of splitting PR codeready-toolchain#443

Signed-off-by: Francesco Ilario <filario@redhat.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (c32a2fa) to head (e1b62e4).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/proxy/handlers/spacelister_list.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files          42       42           
  Lines        2732     2742   +10     
=======================================
+ Hits         2151     2159    +8     
- Misses        489      490    +1     
- Partials       92       93    +1
Flag Coverage Δ
unittests 78.73% <86.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filariow filariow mentioned this pull request Jul 29, 2024
Merged
7 tasks
@filariow filariow marked this pull request as ready for review July 31, 2024 08:30
@filariow
Copy link
Contributor Author

/retest

alexeykazakov
alexeykazakov reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor comments.

pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
@filariow
cleanup tests
9327aaf 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow filariow requested a review from alexeykazakov August 1, 2024 15:13
alexeykazakov
alexeykazakov approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openshift-ci openshift-ci bot added the approved label Aug 1, 2024
mfrancisc
mfrancisc reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

I have only few minor comments/questions.

pkg/proxy/handlers/spacelister_test.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_test.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
filariow added 3 commits August 7, 2024 16:43
@filariow
Update pkg/proxy/handlers/spacelister_list_test.go
256f14f
@filariow
improve tests
a0cc9fd 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
rename test func
2f018f8 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
fix linter complaints
ca493e7 
Signed-off-by: Francesco Ilario <filario@redhat.com>
mfrancisc
mfrancisc approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice job 👏

Thanks for addressing my comments and for the additional improvements to the tests.

pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@filariow
refactor
c913d90 
Signed-off-by: Francesco Ilario <filario@redhat.com>
@filariow
Copy link
Contributor Author

/retest

2 similar comments
@filariow
Copy link
Contributor Author

/retest

@filariow
Copy link
Contributor Author

/retest

@filariow
Copy link
Contributor Author

/retest

as codeready-toolchain/toolchain-e2e#1036 merged

@filariow
Copy link
Contributor Author

/test all

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
10.6% Duplication on New Code

See analysis details on SonarCloud

@filariow filariow merged commit 5faca3a into codeready-toolchain:master Aug 26, 2024
10 of 11 checks passed
@filariow filariow deleted the pv-532-spacelister-list branch August 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancisc mfrancisc mfrancisc approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek MatousJobanek is a code owner

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filariow @alexeykazakov @mfrancisc