Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use FakeClient as backend for InformersService in unit tests #466

Merged
merged 2 commits into from
Sep 25, 2024
Merged

use FakeClient as backend for InformersService in unit tests #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d5777c
use FakeClient as backend for InformersService in unit tests
MatousJobanek Sep 24, 2024
0194c4c
check the object type in mocks
MatousJobanek Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions pkg/controller/usernames_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
package controller_test

import (
"context"
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
"testing"

toolchainv1alpha1 "github.com/codeready-toolchain/api/api/v1alpha1"
"github.com/codeready-toolchain/registration-service/pkg/controller"
"github.com/codeready-toolchain/registration-service/pkg/informers/service"
"github.com/codeready-toolchain/registration-service/pkg/username"
"github.com/codeready-toolchain/registration-service/test"
"github.com/codeready-toolchain/registration-service/test/fake"
commontest "github.com/codeready-toolchain/toolchain-common/pkg/test"
"github.com/gin-gonic/gin"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
"sigs.k8s.io/controller-runtime/pkg/client"
)

type TestUsernamesSuite struct {
Expand All @@ -31,13 +34,13 @@ func (s *TestUsernamesSuite) TestUsernamesGetHandler() {
req, err := http.NewRequest(http.MethodGet, "/api/v1/usernames", nil)
require.NoError(s.T(), err)

fakeClient := fake.InitClient(s.T(),
fakeClient := commontest.NewFakeClient(s.T(),
fake.NewMasterUserRecord("johnny"),
)

s.Run("success", func() {

fakeInformer := fake.GetInformerService(fakeClient)()
fakeInformer := service.NewInformerService(fakeClient, commontest.HostOperatorNs)
s.Application.MockInformerService(fakeInformer)

// Create Usernames controller instance.
Expand Down Expand Up @@ -97,9 +100,11 @@ func (s *TestUsernamesSuite) TestUsernamesGetHandler() {

s.Run("error", func() {
// force error while retrieving MUR
fakeInformer := fake.GetInformerService(fakeClient, fake.WithGetMurFunc(func(_ string) (*toolchainv1alpha1.MasterUserRecord, error) {
return nil, fmt.Errorf("mock error")
}))()
fakeClient := commontest.NewFakeClient(s.T())
fakeClient.MockGet = func(_ context.Context, _ client.ObjectKey, _ client.Object, _ ...client.GetOption) error {
return fmt.Errorf("mock error")
}
fakeInformer := service.NewInformerService(fakeClient, commontest.HostOperatorNs)
s.Application.MockInformerService(fakeInformer)

// Create Usernames controller instance.
Expand Down
Loading
Loading