Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop BaseService from MemberClusterService & use Client directly #477

Merged
merged 3 commits into from
Oct 8, 2024
+36 −98

Merge branch 'master' into drop-baseservice-from-clusterservice

1713c85
Select commit
Loading
Failed to load commit list.
Merged

drop BaseService from MemberClusterService & use Client directly #477

Merge branch 'master' into drop-baseservice-from-clusterservice
1713c85
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 0s

85.43% (-0.03%) compared to fb4418b

View this Pull Request on Codecov

85.43% (-0.03%) compared to fb4418b

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (fb4418b) to head (1713c85).

Files with missing lines Patch % Lines
pkg/proxy/service/cluster_service.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   85.45%   85.43%   -0.03%     
==========================================
  Files          33       33              
  Lines        2523     2519       -4     
==========================================
- Hits         2156     2152       -4     
  Misses        281      281              
  Partials       86       86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov