-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix GetBannedUser #436
fix GetBannedUser #436
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 49 49
Lines 2444 2444
=======================================
Hits 1912 1912
Misses 478 478
Partials 54 54
|
Quality Gate passedIssues Measures |
I forgot that we need to not return an error here in cases where we just want to see if already exists: https://github.com/kubesaw/ksctl/blob/a89cb52c172831ed523b575be62b6b4ea7a4a5aa/pkg/cmd/ban.go#L75 |
Maybe you can return a specific type of error in this case, like:
and update the ksctl function to ignore this error. |
+1 to @mfrancisc suggestion |
Description
We should return an error when no BannedUser is found