KUBESAW-173: Create GH Actions workflow running verify-replace-run target #441
Conversation
…rget Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 49 49
Lines 2444 2444
=======================================
Hits 1912 1912
Misses 478 478
Partials 54 54 |
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
| go-version-file: go.mod | ||
|
|
||
| - name: Install golangci-lint | ||
| run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2 |
There was a problem hiding this comment.
as discussed - my "concern" is that some projects are using golanci-lint v1.56.2 ( see reg-svc , member operator ) . Should we first upgrade all projects to 1.56 ?
There was a problem hiding this comment.
I did try using v1.56.2 here, but it failed with error that it required go 1.21 , so i am a bit confused now, as to how go-lint v1.56.2 works in reg-svc, member-operator.
it may be probably because of pkg/slices as i see that in error, but unsure about this
There was a problem hiding this comment.
maybe @xcoulon knows better
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
This PR creates GH Actions running verify-replace-run target in api and toolchain-common repositories, making sure that the change introduced in the PR doesn't break other repos that depend on that.
Similar PR