Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align UserSignup hepler functions #445

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

align UserSignup hepler functions #445

wants to merge 4 commits into from
+41 −7

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Jan 9, 2025 •
edited
Loading

codeready-toolchain/registration-service#492 (comment)

TODO:

  • as soon as it's approved, update the respective repositories where the renamed functions are used

@MatousJobanek MatousJobanek changed the title align UserSignp hepler functions align UserSignup hepler functions Jan 9, 2025
@MatousJobanek MatousJobanek mentioned this pull request Jan 9, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.23%. Comparing base (010ac13) to head (07205cc).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files          49       49           
  Lines        2444     2444           
=======================================
  Hits         1912     1912           
  Misses        478      478           
  Partials       54       54

mfrancisc
mfrancisc approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Thanks for the renaming.

alexeykazakov
alexeykazakov approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just added a few comments.

pkg/test/usersignup/usersignup.go Show resolved Hide resolved
pkg/test/usersignup/usersignup.go Show resolved Hide resolved
pkg/test/usersignup/usersignup.go Show resolved Hide resolved
MatousJobanek and others added 3 commits January 10, 2025 16:29
@MatousJobanek @alexeykazakov
Update pkg/test/usersignup/usersignup.go
6d2adc9 
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
@MatousJobanek @alexeykazakov
Update pkg/test/usersignup/usersignup.go
ae4cdef 
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
@MatousJobanek @alexeykazakov
Update pkg/test/usersignup/usersignup.go
07205cc 
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancisc mfrancisc mfrancisc approved these changes

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatousJobanek @alexeykazakov @mfrancisc