Issue 12 - Created api view and serializer for registering users. (#41)

* Created api view and serializer for registering users.

* Added additional tests and validators.
Moved bingo urls into bingo/

* Moved validation into serializer.

server/api/urls.py

@@ -18,13 +18,9 @@
 from django.contrib import admin
 from django.urls import path, include
 
-from rest_framework_simplejwt.views import (
-    TokenObtainPairView,
-    TokenRefreshView,
-)
+
 urlpatterns = [
-    path("admin/", admin.site.urls),
-    path("api/healthcheck/", include(("api.healthcheck.urls"))),
-    path('api/token/', TokenObtainPairView.as_view(), name='token_obtain_pair'),
-    path('api/token/refresh/', TokenRefreshView.as_view(), name='token_refresh'),
+    path('admin/', admin.site.urls),
+    # Moved authentication/bingo related urls to bingo/.
+    path('api/', include('bingo.urls')),
 ]

server/bingo/serializers.py

@@ -0,0 +1,30 @@
+from rest_framework import serializers
+from django.contrib.auth import get_user_model
+from django.contrib.auth.password_validation import validate_password
+
+User = get_user_model()
+
+
+class UserRegisterSerializer(serializers.ModelSerializer):
+    class Meta:
+        model = User
+        fields = ['username', 'first_name', 'last_name', 'email', 'password']
+        extra_kwargs = {
+            'password': {'write_only': True},
+            'first_name': {'required': True},
+            'last_name': {'required': True}
+        }
+
+    def create(self, validated_data):
+        user = User.objects.create_user(
+            username=validated_data['username'],
+            first_name=validated_data['first_name'],
+            last_name=validated_data['last_name'],
+            email=validated_data['email'],
+            password=validated_data['password'],
+        )
+        return user
+
+    def validate_password(self, value):
+        validate_password(value)
+        return value

server/bingo/tests.py

@@ -1,6 +1,7 @@
+from django.test import TestCase, Client
 from django.db.utils import IntegrityError
-from django.test import TestCase
 from .models import User, Challenge, Friendship
+
 from django.core.exceptions import ValidationError
 
 
@@ -42,6 +43,44 @@ def test_default_total_completions(self):
         self.assertEqual(challenge.total_completions, 0)
 
 
+class RegisterUserTest(TestCase):
+    def setUp(self):
+        self.client = Client()
+
+    def test_register_user(self):
+        response = self.client.post(
+            '/api/register/', {'username': 'test_user', 'email': 'test@gmail.com',
+                               'first_name': 'larry', 'last_name': 'bird', 'password': 'SuperSecure123'}
+        )
+
+        self.assertEqual(response.status_code, 201)
+
+    # Required fields not sent.
+    def test_register_user_error(self):
+        response = self.client.post(
+            '/api/register/', {'username': 'forgotten_fields', 'email': 'test@gmail.com',
+                               'password': 'SuperSecure123'}
+        )
+
+        self.assertEqual(response.status_code, 400)
+
+    def test_invalid_email_error(self):
+        response = self.client.post(
+            '/api/register/', {'username': 'forgotten_fields', 'email': 'invalidemail',
+                               'first_name': 'larry', 'last_name': 'bird', 'password': 'SuperSecure123'}
+        )
+
+        self.assertEqual(response.status_code, 400)
+
+    def test_insecure_password_error(self):
+        response = self.client.post(
+            '/api/register/', {'username': 'forgotten_fields', 'email': 'test@test.com',
+                               'first_name': 'larry', 'last_name': 'bird', 'password': '1234'}
+        )
+
+        self.assertEqual(response.status_code, 400)
+
+
 class FriendshipTest(TestCase):
     def setUp(self):
         # Create test users

server/bingo/urls.py

@@ -0,0 +1,13 @@
+from django.urls import path
+
+from rest_framework_simplejwt.views import (
+    TokenObtainPairView,
+    TokenRefreshView,
+)
+from bingo import views
+
+urlpatterns = [
+    path('token/', TokenObtainPairView.as_view(), name='token_obtain_pair'),
+    path('token/refresh/', TokenRefreshView.as_view(), name='token_refresh'),
+    path('register/', views.register_user, name='register_user'),
+]

server/bingo/views.py

@@ -1,3 +1,15 @@
-from django.shortcuts import render # noqa
+from rest_framework import status
+from rest_framework.decorators import api_view
+from rest_framework.response import Response
+from .serializers import UserRegisterSerializer
 
 # Create your views here.
+
+
+@api_view(['POST'])
+def register_user(request):
+    serializer = UserRegisterSerializer(data=request.data)
+    if serializer.is_valid():
+        serializer.save()
+        return Response({'User created successfully.'}, status=status.HTTP_201_CREATED)
+    return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)