Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 54 create component for bingo tile #106

Merged
merged 14 commits into from
Jan 18, 2025

Conversation

melbauerr
Copy link
Contributor

@melbauerr melbauerr commented Jan 13, 2025

Change Summary

Create bingo tile component with options for the different props:

  • type (connect/understand/act) determines icon shown
  • text is same on mobile and desktop, on mobile text is only sufficient for 3 words
  • status (not started/started/completed), determines colour of the tile
  • boolean prop reflects whether tile is currently selected - if true, tile is emphasised
Screenshot 2025-01-13 at 12 46 01 pm

Change Form

  • [❌] The pull request title has an issue number
  • [❌] The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

Pull request also includes placeholder Blingo tile page.

Related issue

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blingo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 6:54am

Copy link
Member

@HuxleyBerry HuxleyBerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've just pointed out some minor things. Additionally, I noticed the tiles have a fixed size which makes them too small on desktop. Instead, they should take up the full width and height of their parent. However, that can be addressed in issue #76 instead if you like.

client/src/components/BingoTile.vue Show resolved Hide resolved
client/public/one-man.svg Outdated Show resolved Hide resolved
client/public/man.svg Outdated Show resolved Hide resolved
Copy link
Member

@HuxleyBerry HuxleyBerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melbauerr melbauerr merged commit 8f06a2b into main Jan 18, 2025
7 checks passed
@HuxleyBerry HuxleyBerry deleted the issue-54-Create_component_for_bingo_tile branch January 18, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create component for bingo tile
3 participants