-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 54 create component for bingo tile #106
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've just pointed out some minor things. Additionally, I noticed the tiles have a fixed size which makes them too small on desktop. Instead, they should take up the full width and height of their parent. However, that can be addressed in issue #76 instead if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Create bingo tile component with options for the different props:
Change Form
Other Information
Pull request also includes placeholder Blingo tile page.
Related issue