Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 85 make banner with wavy edge #120

Merged
merged 5 commits into from
Jan 18, 2025
Merged

Conversation

mye9
Copy link
Contributor

@mye9 mye9 commented Jan 18, 2025

Change Summary

Make a wavy banner with full window

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blingo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 4:11am

@mye9 mye9 requested a review from HuxleyBerry January 18, 2025 03:58
@mye9 mye9 self-assigned this Jan 18, 2025
Comment on lines 70 to 74
.custom-container {
max-width: 100% !important;
padding: 0 !important;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the !important's necessary here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check it without !important and it works, i will delete it

@mye9 mye9 merged commit 9100602 into main Jan 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants