Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 95 create api view to request friendship #125

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

yuwengchoong
Copy link
Contributor

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • [ YES] The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • [YES ] The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blingo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 7:51am

Copy link
Member

@HuxleyBerry HuxleyBerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I've just pointed out one unnecessary thing you included in your tests, but otherwise everything looks good.

Comment on lines +37 to +39
with self.assertRaises(ValidationError):
Friendship.objects.create(
requester=self.user1, receiver=self.user1).full_clean()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary since it is already tested in the friendship model tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants