Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 61 add question preview modal component #63

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

leonleerl
Copy link
Contributor

@leonleerl leonleerl commented Jan 15, 2025

Change Summary

In Sidebar:

  • Navigate to Question Pages

In Preview Modal:

  • Render data from the Question Page
  • Use <MathInput> Component
  • Hide and show Solution

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • [T] The pull request title has an issue number
  • [T] The change works by "Smoke testing" or quick testing
  • [NA] The change has tests
  • [T] The change has documentation

Related issue

@leonleerl leonleerl added frontend Task must have a front end issue component labels Jan 15, 2025
@leonleerl leonleerl self-assigned this Jan 15, 2025
@yunho7687
Copy link
Member

hi, could you please attach some screenshots about your work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the naming convention shall be lower case iirc (Question -> question)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the naming convention shall be lower case iirc (Question -> question)

Hi Yunho. I follow the style-guide.md. It says the folder name in /Components should use PascalCase.
Screenshot 2025-01-15 at 4 53 14 pm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, hh, my fault!

@leonleerl
Copy link
Contributor Author

hi, could you please attach some screenshots about your work?

Yes. Here they are.

Screenshot 2025-01-15 at 4 48 04 pm Screenshot 2025-01-15 at 4 48 10 pm

@yunho7687
Copy link
Member

These two buttons should remain at the bottom, close to the bottom edge, regardless of the content length, and the modal box shall stretch when the content is extensive ( no inside scroll-bar in the modal )

@leonleerl
Copy link
Contributor Author

These two buttons should remain at the bottom, close to the bottom edge, regardless of the content length, and the modal box shall stretch when the content is extensive ( no inside scroll-bar in the modal )

Hi Yunho. The problems have been fixed.
Test data:

$$
\begin{array}{|c|c|c|}
\hline
\textbf{X} & \textbf{Y} & \textbf{Linear Equation} \\
\hline
0 & 0 & y = 2x + 1 \\
\hline
1 & 3 & 2(1) + 1 = 3 \\
\hline
2 & 5 & 2(2) + 1 = 5 \\
\hline
3 & 7 & 2(3) + 1 = 7 \\
\hline
4 & 9 & 2(4) + 1 = 9 \\
\hline
5 & 11 & 2(5) + 1 = 11 \\
\hline
\end{array}
$$
Screenshot 2025-01-16 at 2 30 48 pm Screenshot 2025-01-16 at 2 31 01 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component frontend Task must have a front end issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Question Preview Modal Component
2 participants