Skip to content

Commit

Permalink
provisional fix so EC errors do not crash the node on download (#841)
Browse files Browse the repository at this point in the history
  • Loading branch information
gmega authored Jun 25, 2024
1 parent ad53066 commit a55b676
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions codex/node.nim
Original file line number Diff line number Diff line change
Expand Up @@ -240,14 +240,14 @@ proc streamEntireDataset(
self: CodexNodeRef,
manifest: Manifest,
manifestCid: Cid,
): ?!LPStream =
): Future[?!LPStream] {.async.} =
## Streams the contents of the entire dataset described by the manifest.
##
trace "Retrieving blocks from manifest", manifestCid

if manifest.protected:
# Retrieve, decode and save to the local store all EС groups
proc erasureJob(): Future[void] {.async.} =
proc erasureJob(): Future[?!void] {.async.} =
try:
# Spawn an erasure decoding job
let
Expand All @@ -258,10 +258,16 @@ proc streamEntireDataset(
self.taskpool)
without _ =? (await erasure.decode(manifest)), error:
trace "Unable to erasure decode manifest", manifestCid, exc = error.msg
except CatchableError as exc:
# --------------------------------------------------------------------------
# FIXME this is a HACK so that the node does not crash during the workshop.
# We should NOT catch Defect.
except Exception as exc:
trace "Exception decoding manifest", manifestCid, exc = exc.msg
return failure(exc.msg)
# --------------------------------------------------------------------------

asyncSpawn erasureJob()
if err =? (await erasureJob()).errorOption:
return failure(err)

# Retrieve all blocks of the dataset sequentially from the local store or network
trace "Creating store stream for manifest", manifestCid
Expand All @@ -283,7 +289,7 @@ proc retrieve*(

return await self.streamSingleBlock(cid)

self.streamEntireDataset(manifest, cid)
await self.streamEntireDataset(manifest, cid)

proc store*(
self: CodexNodeRef,
Expand Down

0 comments on commit a55b676

Please sign in to comment.