Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename err to error to avoid naming conflict #68

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

tbekas
Copy link
Contributor

@tbekas tbekas commented Jun 4, 2024

Label err in generic procs (which are basically templates) often conflicts with this definition from nim-results: template err*(): auto = err(typeof(result)). Which causes often unexpected compilation errors.

@tbekas tbekas requested review from dryajov and benbierens June 4, 2024 09:42
Copy link
Contributor

@benbierens benbierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what could possibly go wrong!?

Copy link
Member

@gmega gmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmega
Copy link
Member

gmega commented Aug 16, 2024

It's complaining that you haven't signed your commits, @tbekas (or is it really you??)

@tbekas tbekas force-pushed the rename-err-to-error branch from 3ab6b84 to 88864e4 Compare August 19, 2024 08:50
@veaceslavdoina veaceslavdoina merged commit 479353d into master Aug 19, 2024
3 checks passed
@veaceslavdoina veaceslavdoina deleted the rename-err-to-error branch August 19, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants