cleanup

coenm · Aug 15, 2023 · 7f839de · 7f839de
1 parent 4c2d42a
commit 7f839de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/src/RepoM.Api/IO/ModuleBasedRepositoryActionProvider/RepositorySpecificConfiguration.cs b/src/RepoM.Api/IO/ModuleBasedRepositoryActionProvider/RepositorySpecificConfiguration.cs
@@ -27,7 +27,6 @@ public class RepositoryConfigurationReader
     public const string FILENAME = "RepositoryActions.yaml";
     private readonly IAppDataPathProvider _appDataPathProvider;
     private readonly IFileSystem _fileSystem;
-    private readonly JsonDynamicRepositoryActionDeserializer _jsonAppSettingsDeserializer;
     private readonly YamlDynamicRepositoryActionDeserializer _yamlAppSettingsDeserializer;
     private readonly IRepositoryExpressionEvaluator _repoExpressionEvaluator;
     private readonly ILogger _logger;
@@ -36,14 +35,12 @@ public class RepositoryConfigurationReader
     public RepositoryConfigurationReader(
         IAppDataPathProvider appDataPathProvider,
         IFileSystem fileSystem,
-        JsonDynamicRepositoryActionDeserializer jsonAppSettingsDeserializer,
         YamlDynamicRepositoryActionDeserializer yamlAppSettingsDeserializer,
         IRepositoryExpressionEvaluator repoExpressionEvaluator,
         ILogger logger)
     {
         _appDataPathProvider = appDataPathProvider ?? throw new ArgumentNullException(nameof(appDataPathProvider));
         _fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
-        _jsonAppSettingsDeserializer = jsonAppSettingsDeserializer ?? throw new ArgumentNullException(nameof(jsonAppSettingsDeserializer));
         _yamlAppSettingsDeserializer = yamlAppSettingsDeserializer ?? throw new ArgumentNullException(nameof(yamlAppSettingsDeserializer));
         _repoExpressionEvaluator = repoExpressionEvaluator ?? throw new ArgumentNullException(nameof(repoExpressionEvaluator));
         _logger = logger ?? throw new ArgumentNullException(nameof(logger));

diff --git a/...M.Api.Tests/IO/ModuleBasedRepositoryActionProvider/RepositorySpecificConfigurationTest.cs b/...M.Api.Tests/IO/ModuleBasedRepositoryActionProvider/RepositorySpecificConfigurationTest.cs
@@ -38,7 +38,6 @@ public class RepositorySpecificConfigurationTest
 {
     private readonly IAppDataPathProvider _appDataPathProvider;
     private readonly MockFileSystem _fileSystem;
-    private readonly JsonDynamicRepositoryActionDeserializer _jsonAppSettingsDeserializer;
     private readonly YamlDynamicRepositoryActionDeserializer _yamlAppSettingsDeserializer;
     private readonly EasyTestFileSettings _testFileSettings;
     private readonly VerifySettings _verifySettings;
@@ -63,8 +62,8 @@ public RepositorySpecificConfigurationTest()
         _appDataPathProvider = A.Fake<IAppDataPathProvider>();
         A.CallTo(() => _appDataPathProvider.AppDataPath).Returns(_tempPath);
 
-        _jsonAppSettingsDeserializer = DynamicRepositoryActionDeserializerFactory.Create();
-        _yamlAppSettingsDeserializer = new YamlDynamicRepositoryActionDeserializer(_jsonAppSettingsDeserializer);
+        JsonDynamicRepositoryActionDeserializer jsonAppSettingsDeserializer = DynamicRepositoryActionDeserializerFactory.Create();
+        _yamlAppSettingsDeserializer = new YamlDynamicRepositoryActionDeserializer(jsonAppSettingsDeserializer);
 
         var dateTimeTimeVariableProviderOptions = new DateTimeVariableProviderOptions()
         {
@@ -151,7 +150,6 @@ public async Task Create_ShouldRespectMultiSelectRepos()
             new RepositoryConfigurationReader(
                 _appDataPathProvider,
                 _fileSystem,
-                _jsonAppSettingsDeserializer,
                 _yamlAppSettingsDeserializer,
                 _repositoryExpressionEvaluator,
                 NullLogger.Instance));
@@ -178,7 +176,6 @@ public async Task Create_ShouldNotCareAboutMultiSelectRepos_WhenSingleRepo()
             new RepositoryConfigurationReader(
                 _appDataPathProvider,
                 _fileSystem,
-                _jsonAppSettingsDeserializer,
                 _yamlAppSettingsDeserializer,
                 _repositoryExpressionEvaluator,
                 NullLogger.Instance));
@@ -205,7 +202,6 @@ public async Task Create_ShouldOnlyProcessActiveItems()
             new RepositoryConfigurationReader(
                 _appDataPathProvider,
                 _fileSystem,
-                _jsonAppSettingsDeserializer,
                 _yamlAppSettingsDeserializer,
                 _repositoryExpressionEvaluator,
                 NullLogger.Instance));
@@ -232,7 +228,6 @@ public async Task Create_ShouldProcessSeparator1()
             new RepositoryConfigurationReader(
                 _appDataPathProvider,
                 _fileSystem,
-                _jsonAppSettingsDeserializer,
                 _yamlAppSettingsDeserializer,
                 _repositoryExpressionEvaluator,
                 NullLogger.Instance));