-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CollabEditor #539
Conversation
51795a7
to
9e7f19f
Compare
…ranscripts to database
}); | ||
|
||
// TODO: listen textChanged event? | ||
article.text = text; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably try reloading article.text
from GraphQL in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I am not sure if client can know when the article.text is updated. Maybe we can try HocuspocusProvider Events.
|
||
// TODO: listen textChanged event? | ||
article.text = text; | ||
editorView.destroy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we need to do anything to ensure that changes are all synced to Hocuspocus before destroying the prosemirror instance here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's test it on staging tonight~
Text editor
prosemirror-schema-basic
, we can write our own schema when need extra features)Backend
Screenshots
Before
Article list page
Article page
Editing
Article page
placeholder
online user
Done
Article list page
Article page