Use linkifyjs for better url extraction lgic

[Tucchhaa]

#548

[Tucchhaa]

I also could replace all calls of linkify() and nl2br() to by element , but decided to do as less changes as possible. If it's needed, please ask me and I'll do that

[coveralls]

coverage: 71.231% (-0.02%) from 71.246%
when pulling 9f2dd8c on Tucchhaa:add_linkifyjs
into 098ec82 on cofacts:master.

[coveralls]

coverage: 71.231% (-0.02%) from 71.246%
when pulling 9f2dd8c on Tucchhaa:add_linkifyjs
into 098ec82 on cofacts:master.

[MrOrz]

Thank you for your PR @Tucchhaa ! I have deployed your change to staging sites ( https://dev.cofacts.tw/ ) and it will be tested during the dev meeting tonight.

Regarding "replace all calls of linkify() and nl2br() to by element" would you explain more on what you want to achieve?

[Tucchhaa]

Thank you for your PR @Tucchhaa ! I have deployed your change to staging sites ( https://dev.cofacts.tw/ ) and it will be tested during the dev meeting tonight.

Regarding "replace all calls of linkify() and nl2br() to by element" would you explain more on what you want to achieve?

It wouldn't be any functional change, just a small refactoring. I've notived that nl2br() and linkify() are called together almost always, and we could replace them just by tag.

[MrOrz]

Thanks for analyzing the code and make the proposal. Personally I think nl2br and linkify are two separate functions, while always used together, it can be more flexible to keep them separated.

Let me merge this PR and ship to production 🚀