updated code readme and moved relevant content from wiki to readme. #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded guard for debug panel which was crashing.
kkoreilly
requested changes
Jul 26, 2024
code/debugpanel.go
Outdated
| @@ -250,6 +250,12 @@ func (dv *DebugPanel) InitTabs() { | |||
| }) | |||
| } | |||
|
|
|||
| // PanelIsValid checks if panel is valid for use. | |||
| // for outside functions calling in, e.g., textbuf. | |||
| func (dv *DebugPanel) PanelIsValid() bool { | |||
There was a problem hiding this comment.
there is a lot of unexporting that could be done here, but really it doesn't matter as this is not a toolkit and nobody cares.
There was a problem hiding this comment.
It does matter and it is important for us to maintain code quality. It is obviously less urgent and we are not going to go through and clean everything up now, but you should at least make new changes properly.
kkoreilly
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added guard for debug panel which was crashing.