Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major progress on Cogent Mail #354

Merged
merged 75 commits into from
Sep 18, 2024
Merged

Major progress on Cogent Mail #354

merged 75 commits into from
Sep 18, 2024

Conversation

kkoreilly
Copy link
Member

This PR makes many advancements to Cogent Mail, improving its GUI, caching, storage, labeling, actions, and many other things. It is still not fully ready for end-user use, but it is much closer now.

@kkoreilly
start on using core.List for mail messages
11905a6
@kkoreilly
start on MessageListItem
3d0d721
@kkoreilly
more attempts at getting message list working
58014d9
@kkoreilly
forgot that you need to use AddChild for core.Value Init child adding
6bd5d41
@kkoreilly
add theApp
3517ab5
@kkoreilly
improve mail list updating
e35224d
@kkoreilly
improve mail currentCache handling and improve naming
3c1e25c
@kkoreilly
move mailbox tree logic to maker
6472a60
@kkoreilly
start moving updateReadMessage logic to Updater
3bc0f27
@kkoreilly
only updateReadMessage when needed
e6f62f0
@kkoreilly
remove old and unnecessary names for mail widgets
ea44f54
@kkoreilly
add mail list item context menu to list context menu for now
7a24e62
@kkoreilly
start on imapMu
c255b7f
@kkoreilly
add more imapMu coverage
d4a172d
@kkoreilly
use a goroutine in mail MoveMessage to prevent deadlock; with that an…
9d59067 
…d the new imapMu, mail actions such as Move work without hanging while caching is happening!
@kkoreilly
disable text wrap for mail.MessageListItem; prevents cogentcore/core#…
74ad9f3 
…1209 from happening
@kkoreilly
move MoveMessage to mail toolbar
39016f6
@kkoreilly
improve move icon and make message body grow
df13b39
@kkoreilly
support changing address in AddressTextField
ecc7c80
@kkoreilly
skip gmail mailboxes for now
ba0eadc
@kkoreilly
remove unnecessary constant SetSlice calling
101b2db
@kkoreilly
start adding mail shortcuts
a8d3e8a
@kkoreilly
add mail.App.compose
68d700e
@kkoreilly
start on mail reply
9db9cb4
@kkoreilly
set default To for reply in mail to From of original message
b1b18d4
@kkoreilly
add support for In-Reply-To header
eb2ee8a
@kkoreilly
add support for message references
6297365
@kkoreilly
add Re: to reply subject in mail
2ac2f5f
@kkoreilly
add mail.App.reply
0fcee7b
@kkoreilly
add mail ReplyAll
7f37ce8
@kkoreilly
use 2 spaces to create markdown newlines for mail forwarding front ma…
2d8c13f 
…tter
@kkoreilly
fix the mail message writer Close() calls; this was causing the unexp…
b9fd126 
…ected EOF error when reading a message sent from Cogent Mail in Cogent Mail, and it was also causing the HTML formatting to not work in Mac Mail; gmail apparently has some automatic tolerance thing that adds the part closing statements for you, which is why it worked there (it even fixed it in the so-called 'Original Message', so I only saw the actual problem when I downloaded the true original message locally)
@kkoreilly
store cached mail per account as a map to allow for easy many-to-many…
028d210 
… labeling instead of more rigid one-to-many mailboxes
@kkoreilly
use base32 MessageID with .eml extension for cached mail filename
29a1bb9
@kkoreilly
add mail message labels
850e536
@kkoreilly
add more label logic and TODOs
f7afc90
@kkoreilly
fix cached map initialization
3ecd314
@kkoreilly
clean up listCache naming
f246f22
@kkoreilly
only save message content to a file if it is not already cached
947f4e0
@kkoreilly
store a UID for each label/mailbox a message is in
7211b6a
@kkoreilly
start on App.action helper function in mail
49e55af
@kkoreilly
add actionLabels in mail
25801c4
@kkoreilly
clean up mail label naming and start on better label listing
507d813
@kkoreilly
get labels tree working
9fc0785
@kkoreilly
add initial friendlyLabelName to mail
86220c7
@kkoreilly
update the cache in markSeen for mail in addition to IMAP
cf381f9
@kkoreilly
minor comment cleanup
445142c
@kkoreilly
update cached mail labels to be stored per email account
22efacd
@kkoreilly
add mail selectMailbox with selectedMailbox cache to avoid unnecessar…
29d243b 
…y mailbox selection
@kkoreilly
fix nil map panic
0f5caac
@kkoreilly
reselect the mailbox for each caching round in case it has been chang…
a10e77d 
…ed by user actions; no-op if already selected
@kkoreilly
add cacheFilename function for mail
5904a38
@kkoreilly
automatically save the mail cache after each action is completed
4bfd741
@kkoreilly
start on new label dialog
1bf1b9d
@kkoreilly
more work on mail labeling dialog
30d980d
@kkoreilly
more label list gui work
24f47a2
@kkoreilly
update view tags to display in marbles
4da7d86
rcoreilly
rcoreilly approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@rcoreilly rcoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest CacheData -> CacheItem or something more semantic. try to avoid Data except for datafs :)

@rcoreilly rcoreilly merged commit 8679ee2 into main Sep 18, 2024
1 check passed
@rcoreilly rcoreilly deleted the mail branch September 18, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcoreilly rcoreilly rcoreilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkoreilly @rcoreilly