-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: Move unit tests to a subdirectory to allow space for integration tests #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malexw
requested review from
EugeneLightsOn,
scottmx81,
tianjing-li and
a team
as code owners
August 1, 2024 16:00
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 81.38% 77.10% -4.29%
==========================================
Files 199 238 +39
Lines 8354 10455 +2101
==========================================
+ Hits 6799 8061 +1262
- Misses 1555 2394 +839 ☔ View full report in Codecov by Sentry. |
BeatrixCohere
approved these changes
Aug 12, 2024
malexw
requested review from
tomtobac,
abimacarmes and
knajjars
as code owners
August 12, 2024 22:46
tomtobac
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a larger series of testing improvements, this change moves all the current python tests from
backend/tests
to the subdirectorybackend/tests/unit
. This gives us room to add a directory for integration tests with their own config.AI Description
This PR introduces changes to the Makefile and updates several test files.
Makefile
watch
,up
,down
,run-unit-tests
,run-community-tests
,run-integration-tests
,attach
,exec-backend
,exec-db
,migration
,migrate
,downgrade
,reset-db
,setup
,setup-use-community
,win-setup
,lint
,first-run
,win-first-run
,generate-client-web
, andinstall-web
.run-tests
target to includerun-unit-tests
.run-tests
target's dependency onbuild
.Test Files
src/backend/tests/
tosrc/backend/tests/unit/
: configuration.yaml, conftest.py, test_deployments.py, test_agent.py, test_agent_tool_metadata.py, test_blacklist.py, test_citation.py, test_conversation.py, test_document.py, test_file.py, test_message.py, test_organization.py, test_snapshot.py, test_tool_call.py, and test_user.py.src/backend/tests/factories/
andsrc/backend/tests/model_deployments/mock_deployments/
directories and their contents.src/backend/tests/unit/factories/__init__.py
, containing the same contents as the removedsrc/backend/tests/factories/__init__.py
.