Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation to pt-br #19

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Translation to pt-br #19

merged 2 commits into from
Apr 24, 2024

Conversation

dev-araujo
Copy link
Contributor

I had access to the solidity-style-guide in a solidity study group, in the web3dev community on discord . And I believe it could be useful for the Brazilian dev audience to have a version of the doc in Portuguese

@wilsoncusack
Copy link
Contributor

Amazing, thanks!

Copy link

@biasgooseRX biasgooseRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good to me. Thank you. Only question I have is Solitações de pull could maybe just be written "PR" or "Pull Requests"? very minor but I am unsure on this one since I have seen mostly Portuguese speaking devs call it Pull Request without translation.

@dev-araujo
Copy link
Contributor Author

@biasgooseRX
Yes, you are correct. It's common for us to use 'PR' or 'Pull Requests', keeping the original term, but in Brazil, it's also common to use certain 'adaptations' that are not so grammatically correct, such as 'solicitações de pull', 'commitar' (an adaptation for the act of making commits), and things like that.
However, I believe that due to the more formal nature, I can change 'solicitações de pull' to 'Pull Requests'.

Copy link

@biasgooseRX biasgooseRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dev-araujo! Great work, it all looks perfect to me now

@cb-heimdall
Copy link
Collaborator

Review Error for biasgooseRX @ 2024-04-24 18:09:17 UTC
User must have write permissions to review

@wilsoncusack wilsoncusack merged commit df88488 into coinbase:main Apr 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants