Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing BaseConfiguration as default for MongoClient.__init___ #15

Open
jvita opened this issue Apr 30, 2022 · 0 comments
Open

Comments

@jvita
Copy link
Member

jvita commented Apr 30, 2022

I was testing out the updated version of the code (that includes the abstracted Configuration class), and I think it might be better if we remove BaseConfiguration from being the default configuration_type and instead require that it be passed in as an argument.

My problem with having it default to BaseConfiguration is that a user might be unaware that failing to pass in AtomicConfiguration would break things like functions that call aggregate_configuration_summaries. I ran into this problem and didn't catch it until much further down in my workflow pipeline -- not a big problem because I think it's safe to just re-assign client.configuration_type = AtomicConfiguration after the fact, but I think that forcing users to pass it in during instantiation would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant