Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to add ability to use CIDR signatures for IP addresses in coldbox rules #45

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

ryanalbrecht
Copy link

Description

I have a need to allow entire subnets access to a particular application. I would like to propose the following changes to allow this. This is fairly a big change due to a new module dependency so would like to hear your thoughts on this.

Please note that all PRs must have tests attached to them

tests to follow

Type of change

I have written and published a new module ( https://forgebox.io/view/ip ) and made changes to cbSecurity to use it so as to allow for CIDR addresses.

  • New Feature

Checklist

  • My code follows the style guidelines of this project cfformat
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ryanalbrecht ryanalbrecht marked this pull request as draft September 5, 2023 18:54
@lmajano
Copy link
Contributor

lmajano commented Sep 12, 2023

I think this looks great. Let me know when you want me to finalize and merge.

@lmajano
Copy link
Contributor

lmajano commented Sep 13, 2023

@ryanalbrecht is this ready to be merged?

@ryanalbrecht
Copy link
Author

@lmajano Good morning Luis,

Thinking about it I would like a couple more days to work on the ip module. The validation code for an ip address when instating the cfc could use some love.

Will let you know when Im comfortable sending this out into the wild.

Regards
Ryan

@lmajano
Copy link
Contributor

lmajano commented Sep 13, 2023

No problem at all. We can also assist with your IP module if you like. I know @bdw429s loves that kinda stuff!

@ryanalbrecht
Copy link
Author

Sure, I will shoot him a message on slack

@lmajano
Copy link
Contributor

lmajano commented Oct 10, 2023

Any updates on this PR @ryanalbrecht

@ryanalbrecht
Copy link
Author

ryanalbrecht commented Oct 10, 2023

Any updates on this PR @ryanalbrecht

@lmajano Unfortunately I have not done any further development, I have been a bit swamped lately. I do actually intend to use this in one of the projects im working on so I will definitely get this code committed soon

@ryanalbrecht ryanalbrecht marked this pull request as ready for review October 12, 2023 14:26
@ryanalbrecht
Copy link
Author

ryanalbrecht commented Oct 12, 2023

Ready to commit, is it possible to rerun the tests to make sure all are passing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants