missing operator

colesbury · Aug 22, 2023 · 67aaa03 · 67aaa03
1 parent 38837c9
commit 67aaa03
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/Include/pyatomic_msc.h b/Include/pyatomic_msc.h
@@ -191,6 +191,18 @@ _Py_atomic_exchange_int(volatile int *address, int value)
     return (int)_InterlockedExchange((volatile long*)address, (long)value);
 }
 
+static inline int8_t
+_Py_atomic_exchange_int8(volatile int8_t *address, int8_t value)
+{
+    return (int8_t)_InterlockedExchange8((volatile short*)address, (short)value);
+}
+
+static inline int16_t
+_Py_atomic_exchange_int16(volatile int16_t *address, int16_t value)
+{
+    return (int16_t)_InterlockedExchange16((volatile short*)address, (short)value);
+}
+
 static inline int32_t
 _Py_atomic_exchange_int32(volatile int32_t *address, int32_t value)
 {

diff --git a/Modules/_testcapi/pyatomic.c b/Modules/_testcapi/pyatomic.c
@@ -11,13 +11,15 @@
 #include "pyatomic.h"
 #include "parts.h"
 
-#define FOR_UNSIGNED_TYPES(V)   \
+// We define atomic bitwise operations on these types
+#define FOR_BITWISE_TYPES(V)    \
     V(uint8, uint8_t)           \
     V(uint16, uint16_t)         \
     V(uint32, uint32_t)         \
     V(uint64, uint64_t)         \
     V(uintptr, uintptr_t)
 
+// We define atomic addition on these types
 #define FOR_ARITHMETIC_TYPES(V) \
     FOR_UNSIGNED_TYPES(V)       \
     V(int, int)                 \
@@ -28,6 +30,7 @@
     V(intptr, intptr_t)         \
     V(ssize, Py_ssize_t)
 
+// We define atomic load, store, exchange, and compare_exchange on these types
 #define FOR_ALL_TYPES(V)        \
     FOR_ARITHMETIC_TYPES(V)     \
     V(ptr, void*)