Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered when parse is executed through
isOptional
check onZodBigInt
which adds aundefined
safeParse execution to look for errors, it crashes when attempting to addundefined
to BigInt as its an invalid value.One fix here is to just try catch the instantiation and cast the coerced value to
undefined
if it throws and error. This way all parser checks will fail on invalid values but not crash on internal checks which provides undefined as the input value.Perhaps another approach could be to just catch and ignore the error and let the input data checks to subsequently verify that the input value is valid. 🤔
closes #3821