Merge pull request #92 from aaajeetee/revert-array-constant

Revert the array constant, use the private static array again. This d…
colinmollenhour · Oct 5, 2017 · 696f224 · 696f224
2 parents 5b1647a + 4484f4c
commit 696f224
Showing 1 changed file with 56 additions and 57 deletions.
diff --git a/Cluster.php b/Cluster.php
@@ -276,65 +276,64 @@ public function hash($key)
     return $this->ring[$server];
   }
 
-  const readOnlyCommands = array(
-    'DBSIZE' => true,
-    'INFO' => true,
-    'MONITOR' => true,
-    'EXISTS' => true,
-    'TYPE' => true,
-    'KEYS' => true,
-    'SCAN' => true,
-    'RANDOMKEY' => true,
-    'TTL' => true,
-    'GET' => true,
-    'MGET' => true,
-    'SUBSTR' => true,
-    'STRLEN' => true,
-    'GETRANGE' => true,
-    'GETBIT' => true,
-    'LLEN' => true,
-    'LRANGE' => true,
-    'LINDEX' => true,
-    'SCARD' => true,
-    'SISMEMBER' => true,
-    'SINTER' => true,
-    'SUNION' => true,
-    'SDIFF' => true,
-    'SMEMBERS' => true,
-    'SSCAN' => true,
-    'SRANDMEMBER' => true,
-    'ZRANGE' => true,
-    'ZREVRANGE' => true,
-    'ZRANGEBYSCORE' => true,
-    'ZREVRANGEBYSCORE' => true,
-    'ZCARD' => true,
-    'ZSCORE' => true,
-    'ZCOUNT' => true,
-    'ZRANK' => true,
-    'ZREVRANK' => true,
-    'ZSCAN' => true,
-    'HGET' => true,
-    'HMGET' => true,
-    'HEXISTS' => true,
-    'HLEN' => true,
-    'HKEYS' => true,
-    'HVALS' => true,
-    'HGETALL' => true,
-    'HSCAN' => true,
-    'PING' => true,
-    'AUTH' => true,
-    'SELECT' => true,
-    'ECHO' => true,
-    'QUIT' => true,
-    'OBJECT' => true,
-    'BITCOUNT' => true,
-    'TIME' => true,
-    'SORT' => true,
-    );
-
   public function isReadOnlyCommand($command)
   {
-      return array_key_exists(strtoupper($command), static::readOnlyCommands);
+      static $readOnlyCommands = array(
+          'DBSIZE' => true,
+          'INFO' => true,
+          'MONITOR' => true,
+          'EXISTS' => true,
+          'TYPE' => true,
+          'KEYS' => true,
+          'SCAN' => true,
+          'RANDOMKEY' => true,
+          'TTL' => true,
+          'GET' => true,
+          'MGET' => true,
+          'SUBSTR' => true,
+          'STRLEN' => true,
+          'GETRANGE' => true,
+          'GETBIT' => true,
+          'LLEN' => true,
+          'LRANGE' => true,
+          'LINDEX' => true,
+          'SCARD' => true,
+          'SISMEMBER' => true,
+          'SINTER' => true,
+          'SUNION' => true,
+          'SDIFF' => true,
+          'SMEMBERS' => true,
+          'SSCAN' => true,
+          'SRANDMEMBER' => true,
+          'ZRANGE' => true,
+          'ZREVRANGE' => true,
+          'ZRANGEBYSCORE' => true,
+          'ZREVRANGEBYSCORE' => true,
+          'ZCARD' => true,
+          'ZSCORE' => true,
+          'ZCOUNT' => true,
+          'ZRANK' => true,
+          'ZREVRANK' => true,
+          'ZSCAN' => true,
+          'HGET' => true,
+          'HMGET' => true,
+          'HEXISTS' => true,
+          'HLEN' => true,
+          'HKEYS' => true,
+          'HVALS' => true,
+          'HGETALL' => true,
+          'HSCAN' => true,
+          'PING' => true,
+          'AUTH' => true,
+          'SELECT' => true,
+          'ECHO' => true,
+          'QUIT' => true,
+          'OBJECT' => true,
+          'BITCOUNT' => true,
+          'TIME' => true,
+          'SORT' => true,
+      );
+      return array_key_exists(strtoupper($command), $readOnlyCommands);
   }
 }