Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate delay(referencedNode, ..., best_guess) in node summary #77

Open
tedchwang opened this issue Jan 12, 2021 · 0 comments
Open

validate delay(referencedNode, ..., best_guess) in node summary #77

tedchwang opened this issue Jan 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@tedchwang
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When a formula contains a delay that uses "best_guess" as the initial value, we should validate whether the referenced node contains a "latest value". Otherwise, calcWorker may give cryptic errors like: TypeError: Unexpected type of argument in function multiplyScalar (expected: number or Complex or BigNumber or Fraction or Unit or string or boolean, actual: undefined, index: 0)

Describe the solution you'd like
It'd be nice to have validation when the formula is entered.

Describe alternatives you've considered
It's also possible to validate during a simulation run, but it should be better to help users detect this type of error early.

@tedchwang tedchwang added the enhancement New feature or request label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant