Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encoding issues when using umlauts in from/to headers #405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix encoding issues when using umlauts in from/to headers #405

wants to merge 1 commit into from

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented May 16, 2023

No description provided.

@MrTango MrTango requested a review from petschki May 16, 2023 10:07
petschki
petschki previously requested changes May 16, 2023
View reviewed changes
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use plone.base.utils.safe_bytes instead.

And the import at the top should be changed to plone.base.utils.safe_text

@MrTango MrTango force-pushed the fix_encoding_for_utf8_headers branch 3 times, most recently from b2654ad to db6dbf0 Compare May 16, 2023 10:46
mauritsvanrees
mauritsvanrees approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@mauritsvanrees mauritsvanrees dismissed petschki’s stale review July 27, 2023 15:17

Requested changes have been made.

@mauritsvanrees
Copy link
Member

I rebased on master and force-pushed.

@mauritsvanrees
Copy link
Member

Lots of test failures like this:

AttributeError: 'bytes' object has no attribute 'encode'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@petschki petschki petschki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrTango @mauritsvanrees @petschki