Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks are not persisted on save action and clicking on add icon triggers a save warning #10

Open
ichim-david opened this issue Jan 26, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@ichim-david
Copy link
Member

With a simple volto app created and using only volto-dropdown menu as seen in the following package.json
https://gist.github.com/ichim-david/d42165da776faa6f1774bbc57e9243b4

When I try to add a block as soon as I click on the add icon I get a save action as seen in the screenshot
save-triggered-on-click

I then add a listing block and I hit the save icon trying to save
save-from-save-icon

Then I add a new menu item
new-menu-item-added

And when I go to check the previous menu item the block data is gone both from edit on missing in view
block-is-now-missing

@ichim-david ichim-david added the bug Something isn't working label Jan 26, 2021
@ichim-david
Copy link
Member Author

@nzambello I know that package.json uses volto 9 however I have another project where I use 10.9 and it behaves the same.
There I have a bunch of volto-slate plus volto-slate-addons and I though that maybe it interfered with this package given that
it's another text editor however even on this clean project it behaves the same.

@ichim-david
Copy link
Member Author

@giuliaghisini ^

@giuliaghisini
Copy link
Collaborator

@giuliaghisini ^

because you've to use this volto's branch formFnOnUpdateFormData that is waiting to be merged in master

@ichim-david
Copy link
Member Author

@giuliaghisini on further inspection of your comment I realized that you were referring to a branch within volto core
https://github.com/plone/volto/tree/formFnOnUpdateFormData
Still there is no mention of such a branch needed within ticket package.

I will try to have a look and see if I can figure out further what is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants