Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIFT scores from VLFeat #8

Open
mihaidusmanu opened this issue Jun 9, 2021 · 1 comment
Open

SIFT scores from VLFeat #8

mihaidusmanu opened this issue Jun 9, 2021 · 1 comment

Comments

@mihaidusmanu
Copy link
Collaborator

There is no easy way to get detection scores out of VLFeat. The current approach is very hacky and bug-prone as I recover the scores directly from the DoG pyramid. The following line should be thoroughly verified.

https://github.com/mihaidusmanu/pycolmap/blob/61fbe2748a15717fcbeaee717fb5a1405f978c34/sift.cc#L102
@mihaidusmanu mihaidusmanu mentioned this issue Jun 9, 2021
Closed
@ahojnnes
Copy link
Contributor

How about making this change inside COLMAP? We can extend the FeatureKeypoint struct with a score and also extend the SQLite database schema with an extra column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahojnnes @mihaidusmanu