Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings when using cask because of zipped #151

Closed
OndrejSpanel opened this issue Nov 26, 2024 · 4 comments
Closed

Deprecation warnings when using cask because of zipped #151

OndrejSpanel opened this issue Nov 26, 2024 · 4 comments

Comments

@OndrejSpanel
Copy link
Contributor

This line from #137 is causing deprecation warnings when compiling against 0.10.1 with deprecations enabled:

https://github.com/com-lihaoyi/cask/blame/fae83f8ed17518574f0f6e1200bbd8a049bc1811/cask/src-3/cask/router/Macros.scala#L264

(sigss, argss, ctxs).zipped.map { case (sigs, args, ctx) =>

With fatal warnings this is fatal (sic):

[error] C:\home\runner\work\cask\cask\cask\src-3\cask\router\Macros.scala: method zipped in class Ops is deprecated since 2.13.0: Use xs.lazyZip(ys).lazyZip(zs)

@jodersky
Copy link
Member

mea culpa on this one. I think if you replace that line with sigss.lazyZip(argss).lazyZip(ctxs), as the message suggests, the warning should go away.

@OndrejSpanel
Copy link
Contributor Author

This is in a macro, therefore you do not get the warnings only when compiling the library, but also when you are just using it (linking to it).

@OndrejSpanel
Copy link
Contributor Author

I will try to prepare a PR.

OndrejSpanel added a commit to OndrejSpanel/cask that referenced this issue Nov 26, 2024
jodersky pushed a commit that referenced this issue Nov 27, 2024
As suggested in #151

(Fix implemented blindly from web UI only, CI passed on the fork)
@jodersky
Copy link
Member

Closed by #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants