Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Soft-Delete for SCL-Files #464

Open
david-monichi-bp opened this issue Nov 19, 2024 · 4 comments · May be fixed by #467
Open

Implement Soft-Delete for SCL-Files #464

david-monichi-bp opened this issue Nov 19, 2024 · 4 comments · May be fixed by #467
Labels
enhancement New feature or request

Comments

@david-monichi-bp
Copy link

User Story

As an user

I want to be able to delete files

So that they are not visible via standard API but can be searched trough with an additional endpoint.

Acceptance criteria

  • Soft-Delete functionality must be disabled by default for an installation so that a system behaves as before without any additional changes.
  • The existing endpoints do behave as before even when soft-delete is enabled, which means that when the feature Soft-Delete is enabled files can't be accessed via existing endpoints and the system will return a 404 in such cases.
  • With an additional added search endpoint it's possible to search trough all SCD-Files (soft-delete or not soft-deleted), soft-deleted files will be marked as deleted
  • the backend will detect already deleted files and versions. Which means that a version can't be redistributed twice when a SCD-File has been soft-deleted und re-uploaded again. The system is aware of all previous versions and will handle versions conflicts over a given resource identified by there id.
@david-monichi-bp david-monichi-bp added the enhancement New feature or request label Nov 19, 2024
@Sander3003
Copy link
Member

Looks good to me!

@Sander3003 Sander3003 reopened this Nov 21, 2024
@david-monichi-bp david-monichi-bp changed the title Implement Soft-Delete for SCD-Files Implement Soft-Delete for SCL-Files Dec 10, 2024
@david-monichi-bp david-monichi-bp mentioned this issue Dec 10, 2024
Open
@pascalwilbrink pascalwilbrink linked a pull request Dec 11, 2024 that will close this issue
Open
@Sander3003
Copy link
Member

Sander3003 commented Dec 13, 2024 •
edited
Loading

@david-monichi-bp can you check @pascalwilbrink pull request to see if it matches this ticket?

@david-monichi-bp
Copy link
Author

Hi, for sure this are required changes but this feature we implemented for TransnetBW is going little bit further. Would it be ok to add us as developers and we bring our solution to a feature branch so that we can discuss about concrete changes via PR?

@Sander3003
Copy link
Member

Sounds like a plan! I will add you

david-monichi-bp added a commit that referenced this issue Dec 17, 2024
@david-monichi-bp
[#464] implement extended soft-delete functionality
da2cece
david-monichi-bp added a commit that referenced this issue Dec 17, 2024
@david-monichi-bp
[#464] added history API implementation
166a904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Soft deletion in scl files com-pas/compas-scl-data-service
2 participants
@Sander3003 @david-monichi-bp