Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#359): use a POJO for allowed FCDA list in CB Report for HMI cre… #360

Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat(#359): use a POJO for allowed FCDA list in CB Report for HMI cre… #360

merged 1 commit into from
Dec 7, 2023

Conversation

AliouDIAITE
Copy link
Member

…ation

@AliouDIAITE AliouDIAITE self-assigned this Dec 1, 2023
samirromdhani
samirromdhani reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@samirromdhani samirromdhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FcdaCsvHelper and its related functions can be removed.

sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ldevice/LDeviceAdapter.java Show resolved Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ldevice/LDeviceAdapter.java Outdated Show resolved Hide resolved
@samirromdhani
Copy link
Contributor

Related to #359

@AliouDIAITE AliouDIAITE force-pushed the feat/359_update_cb_report_for_hmi_creation_sonfig_file branch from 83ec957 to e63d8de Compare December 7, 2023 09:42
samirromdhani
samirromdhani requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@samirromdhani samirromdhani left a comment •
edited by AliouDIAITE
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AliouDIAITE AliouDIAITE force-pushed the feat/359_update_cb_report_for_hmi_creation_sonfig_file branch from e63d8de to 2c2f828 Compare December 7, 2023 09:48
@AliouDIAITE AliouDIAITE force-pushed the feat/359_update_cb_report_for_hmi_creation_sonfig_file branch from 2c2f828 to 1ee2aba Compare December 7, 2023 10:06
@AliouDIAITE AliouDIAITE linked an issue Dec 7, 2023 that may be closed by this pull request
[RSR-817] : Use generated Pojo defined in xsd file for configuration data for CB Report creation for HMI #359
Closed
@samirromdhani samirromdhani self-requested a review December 7, 2023 10:44
@AliouDIAITE
feat(#359): use a POJO for allowed FCDA list in CB Report for HMI cre…
5804ec2 
…ation

Signed-off-by: Aliou DIAITE <aliou.diaite@rte-france.com>
@AliouDIAITE AliouDIAITE force-pushed the feat/359_update_cb_report_for_hmi_creation_sonfig_file branch from 1ee2aba to 5804ec2 Compare December 7, 2023 10:52
@AliouDIAITE AliouDIAITE merged commit 9cce141 into develop Dec 7, 2023
9 checks passed
@AliouDIAITE AliouDIAITE deleted the feat/359_update_cb_report_for_hmi_creation_sonfig_file branch December 7, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massifben massifben Awaiting requested review from massifben

@gleizesDor gleizesDor Awaiting requested review from gleizesDor

@samirromdhani samirromdhani Awaiting requested review from samirromdhani

Assignees

@AliouDIAITE AliouDIAITE

Labels
None yet
Projects
CoMPAS Pull Request Overview Board
Status: Done
CoMPAS SCT Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RSR-817] : Use generated Pojo defined in xsd file for configuration data for CB Report creation for HMI
2 participants
@AliouDIAITE @samirromdhani