Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#378): remove validation when DOI(Mod) and DAI(stVal) does not exists #377

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat(#378): remove validation when DOI(Mod) and DAI(stVal) does not exists #377

merged 2 commits into from
Feb 28, 2024

Conversation

samirromdhani
Copy link
Contributor

@samirromdhani samirromdhani commented Feb 22, 2024 •
edited
Loading

This pull tries to remove validation when DOI(Mod) and DAI(stVal) does not exists:

Changes in existing issues:

  1. Remove the binding when source or target IED is off or signal is Inactive - Part 2/3

Error messages:

If the status of the source LDevice ou the target LDevice is not defined then the processing is aborted and an error message is returned: "The IED@name/LDevice@inst has no "on" or "off" status. End of the processing".

==> Error message removed and the LDevice considered as "on"

  1. Setting of LDEPF LDevices and its RADR and RBDR Logical Nodes

Functional Rules
Description:

Step 1 : In SCD file, find all LDevice@inst="LDEPF" which are active. Then find each IED@name and Bay UUID where these LDEPF LDevice reside. Exclude the IED@name="IEDTEST" and its LDEPF LDevice. If there is no DOI@name="Mod"/DAI@name="stVal"/Val then an error message is returned ERR_01

==> Error message (ERR_01) removed and the LDevice considered as "on", Maintaining the verification in DataTypeTemplate of DO(Mod)/DA(stVal)

@samirromdhani samirromdhani force-pushed the feat/RSR-924_remove_validation_when_specific_DOI_and_DAI_does_not_exists branch 2 times, most recently from 3b04976 to 1f22d0c Compare February 22, 2024 13:34
@samirromdhani samirromdhani changed the title feat(): remove validation when DOI(Mod) and DAI(stVal) does not exists feat(#378): remove validation when DOI(Mod) and DAI(stVal) does not exists Feb 22, 2024
@samirromdhani
feat(#378): remove validation when DOI(Mod) and DAI(stVal) does not e…
e230c11 
…xists

closes #378

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
@samirromdhani samirromdhani force-pushed the feat/RSR-924_remove_validation_when_specific_DOI_and_DAI_does_not_exists branch from 1f22d0c to e230c11 Compare February 22, 2024 14:36
@samirromdhani samirromdhani linked an issue Feb 22, 2024 that may be closed by this pull request
[RSR-924] COMPAS - Remove restriction when DAI="mod"/DOI="stVal" doesn't exist or is empty in IED/LD/LN0 #378
Closed
@samirromdhani samirromdhani marked this pull request as ready for review February 22, 2024 15:11
@samirromdhani
feat(#378): code review
7529951 
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
@samirromdhani samirromdhani merged commit 702a8d8 into develop Feb 28, 2024
8 checks passed
@samirromdhani samirromdhani deleted the feat/RSR-924_remove_validation_when_specific_DOI_and_DAI_does_not_exists branch February 28, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleizesDor gleizesDor gleizesDor approved these changes

@massifben massifben Awaiting requested review from massifben

@AliouDIAITE AliouDIAITE Awaiting requested review from AliouDIAITE

Assignees
No one assigned
Labels
None yet
Projects
CoMPAS Pull Request Overview Board
Status: Done
CoMPAS SCT Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RSR-924] COMPAS - Remove restriction when DAI="mod"/DOI="stVal" doesn't exist or is empty in IED/LD/LN0
2 participants
@samirromdhani @gleizesDor