Merge pull request #18 from comet-ml/mysql8

Switch to MySQL 8 as default in RDS
comet-ml · Apr 8, 2024 · 0353ef2 · 0353ef2
2 parents aabc737 + b48e3d7
commit 0353ef2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/modules/comet_rds/main.tf b/modules/comet_rds/main.tf
@@ -46,7 +46,7 @@ resource "aws_rds_cluster" "cometml-db-cluster" {
 
 resource "aws_rds_cluster_parameter_group" "cometml-cluster-pg" {
   name        = "cometml-rds-cluster-pg-${var.environment}"
-  family      = "aurora-mysql5.7"
+  family      = "aurora-mysql${var.rds_engine_version}"
   description = "CometML RDS cluster parameter group"
 
   parameter {
@@ -109,6 +109,11 @@ resource "aws_rds_cluster_parameter_group" "cometml-cluster-pg" {
     name         = "log_bin_trust_function_creators"
     value        = "1"
   }
+  parameter {
+    apply_method = "pending-reboot"
+    name         = "thread_stack"
+    value        = "6291456"
+  }
 }
 
 resource "aws_security_group" "mysql_sg" {

diff --git a/variables.tf b/variables.tf
@@ -278,7 +278,7 @@ variable "rds_engine" {
 variable "rds_engine_version" {
   description = "Engine version number for RDS database"
   type        = string
-  default     = "5.7"
+  default     = "8.0"
 }
 
 variable "rds_instance_type" {