fix: Fix Cypress #588
Merged
fix: Fix Cypress #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyEPhipps
commented
Sep 27, 2023
| @@ -63,17 +65,11 @@ describe('Button component', () => { | |||
| .find('textarea') | |||
| .should('exist'); | |||
| }); | |||
|
|
|||
| it('closes code on click', () => { | |||
There was a problem hiding this comment.
For whatever reason, these steps were causing tests to fail, even though the functionality works fine locally.
Given that this is testing CL itself, rather than our code, it seemed like a waste of time and energy to debug this right now, so I pulled out every instance of it across our tests.
KrupaPammi
approved these changes
Sep 27, 2023
|
One thing to note, this test suite now takes AGES, so it might be a good idea for us to audit all of these tests in the near future I'd maybe question the need to run all the tests again on merge, after the branch has already passed; perhaps that's something to evaluate too. |
|
🎉 This PR is included in version 7.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
Addresses Cypress failures that arrived out of nowhere (possibly underlying Chrome engine updates happening in the background), which are blocking us from releasing any new versions of the CL.
The PR updates Cypress and also updates the tests to suit the new requirements.
Why is this required?
CL BROKED
link to Jira ticket:
Add a link to the Jira ticket.
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...