Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add playwright package and tests to run on GH actions #592

Merged
merged 27 commits into from
Nov 16, 2023
Merged

test: add playwright package and tests to run on GH actions #592

merged 27 commits into from
Nov 16, 2023

Conversation

KrupaPammi
Copy link
Contributor

No description provided.

@KrupaPammi KrupaPammi changed the title add playwright package and tests to run on GH actions test: add playwright package and tests to run on GH actions Oct 6, 2023
@KrupaPammi KrupaPammi mentioned this pull request Oct 17, 2023
Merged
4 tasks
@KrupaPammi
Copy link
Contributor Author

Hi @AndyEPhipps, this PR is ready for review.

I see some problems with lint; I'm not sure how to fix them. Would you be able to look into it please?

Screenshot 2023-11-16 at 09 01 19

AndyEPhipps
AndyEPhipps approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@AndyEPhipps AndyEPhipps left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot going on here, but I trust your work!

Will need to look into those GitHubAction Lint errors in another PR if we can

I see some problems with lint; I'm not sure how to fix them. Would you be able to look into it please?

Ah sorry, didn't see this comment. Will see what I can do now in this PR.

@AndyEPhipps
Copy link
Contributor

Have fixed those; it seems like Actions is using a different Linting ruleset to what's used locally; will suss out how to align these in the near future.

@KrupaPammi
Copy link
Contributor Author

Have fixed those; it seems like Actions is using a different Linting ruleset to what's used locally; will suss out how to align these in the near future.

Thanks Andy

@KrupaPammi KrupaPammi merged commit 79cb1ab into master Nov 16, 2023
9 checks passed
@KrupaPammi KrupaPammi deleted the migrate_cypress_to_playwright_tests branch November 16, 2023 11:55
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.24.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyEPhipps AndyEPhipps AndyEPhipps approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrupaPammi @AndyEPhipps