QueryAll with sort order other than by id returns duplicate and incomplete search results.

[tomwscott]

I'm not sure if this is an issue or a feature request but if the query passed to QueryUtils applies a sort order other than by id the search results after the first page will be incomplete and likely include duplicate results.

Whilst it is hinted at in the code documentation, there is nothing that explicitly prevents a sort order being added as part of the query which then breaks the assumption here:

commercetools-sdk-java-v2/commercetools/commercetools-sdk-java-api/src/main/java/com/commercetools/api/client/QueryAll.java

Line 160 in 615f3c4

return baseQuery.addWhere("id > :lastId", "lastId", lastElementId).execute();

For my use case it would be great to be able fetch all results ordered by key.

If the only supported mechanism in the library for querying all entities is when ordered by id it would be great to have that as part of the function name to make it explicit.

[jenschude]

The QueryAll is a helper class to conveniently get all elements of a query without the limitations from using offset & limit query parameters. As a matter of fact it has limitations itself which means that the result must be sorted by ID too else the algorithm it not working correctly as described here: https://docs.commercetools.com/api/general-concepts#iterating-over-all-elements

If you already sort by key you may have to add an additional sort by ID in your request cause the sort by ID would not be added as can be seen here:

commercetools-sdk-java-v2/commercetools/commercetools-sdk-java-api/src/main/java/com/commercetools/api/client/QueryAll.java

Line 41 in 74e2a9a

return !withLimit.getQueryParam("sort").isEmpty() ? withLimit : withLimit.withSort("id asc");

So to have a different option for paging the result is a feature request and I don't know if or when we could work on it.

Besides you are still free to use the implementation as a starting point to adjust it to your needs.