-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): add new asset template #81
Conversation
|
f8f21b3
to
c908b52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this is looking good.
Nit: we should not add spaces around text inside a JSX tag. Or am I incorrect?
Hey @markkovari-commercetools you're correct! It looks like the prettier missed the |
Co-authored-by: Mark Kovari <114930336+markkovari-commercetools@users.noreply.github.com>
Co-authored-by: Mark Kovari <114930336+markkovari-commercetools@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
4f0acb4
to
6efa79d
Compare
6efa79d
to
4291541
Compare
@markkovari-commercetools @harm-meijer, I changed the configuration to a simpler one. I don't know if you want to review it again, please. Thanks |
🥷 Code experts: no user matched threshold 10 See details
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
b5b3533
to
83f1340
Compare
Link to the Jira issue
IM-974 https://jira.commercetools.com/browse/IM-974
Add asset template