Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): add new asset template #81

Merged
merged 12 commits into from
Jul 22, 2024
Merged

feat(templates): add new asset template #81

merged 12 commits into from
Jul 22, 2024

Conversation

ruidias-commercetools
Copy link
Contributor

@ruidias-commercetools ruidias-commercetools commented Jul 10, 2024

Link to the Jira issue

IM-974 https://jira.commercetools.com/browse/IM-974

Add asset template

Copy link

changeset-bot bot commented Jul 10, 2024

⚠️ No Changeset found

Latest commit: 03b8a6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ruidias-commercetools ruidias-commercetools changed the title feat(templates): add new asset typescript template feat(templates): add new asset template Jul 10, 2024
@ruidias-commercetools ruidias-commercetools marked this pull request as ready for review July 10, 2024 11:23
Copy link
Contributor

@markkovari-commercetools markkovari-commercetools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is looking good.

Nit: we should not add spaces around text inside a JSX tag. Or am I incorrect?

application-templates/javascript/assets/index.html Outdated Show resolved Hide resolved
application-templates/typescript/assets/index.html Outdated Show resolved Hide resolved
@ruidias-commercetools
Copy link
Contributor Author

Hey @markkovari-commercetools you're correct! It looks like the prettier missed the index.html. I'll try to update the settings there!

ruidias-commercetools and others added 2 commits July 16, 2024 11:29
Co-authored-by: Mark Kovari <114930336+markkovari-commercetools@users.noreply.github.com>
Co-authored-by: Mark Kovari <114930336+markkovari-commercetools@users.noreply.github.com>
Copy link
Contributor

@markkovari-commercetools markkovari-commercetools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

application-templates/javascript/assets/src/main.js Outdated Show resolved Hide resolved
application-templates/typescript/assets/package.json Outdated Show resolved Hide resolved
application-templates/typescript/assets/package.json Outdated Show resolved Hide resolved
application-templates/typescript/assets/package.json Outdated Show resolved Hide resolved
application-templates/typescript/assets/package.json Outdated Show resolved Hide resolved
@ruidias-commercetools
Copy link
Contributor Author

@markkovari-commercetools @harm-meijer, I changed the configuration to a simpler one. I don't know if you want to review it again, please. Thanks

Copy link

gitstream-cm bot commented Jul 20, 2024

🥷 Code experts: no user matched threshold 10

See details

.eslintignore

Knowledge based on git-blame:

.eslintrc.cjs

Knowledge based on git-blame:

.nvmrc

Knowledge based on git-blame:

application-templates/javascript/event/.nvmrc

Knowledge based on git-blame:

application-templates/javascript/job/.nvmrc

Knowledge based on git-blame:

application-templates/javascript/service/.nvmrc

Knowledge based on git-blame:

application-templates/typescript/.gitignore

Knowledge based on git-blame:

application-templates/typescript/event/.nvmrc

Knowledge based on git-blame:

application-templates/typescript/job/.nvmrc

Knowledge based on git-blame:

application-templates/typescript/service/.nvmrc

Knowledge based on git-blame:

package-lock.json

Knowledge based on git-blame:

package.json

Knowledge based on git-blame:

packages/create-connect-app/.nvmrc

Knowledge based on git-blame:

packages/create-connect-app/package.json

Knowledge based on git-blame:

To learn more about /:\ gitStream - Visit our Docs

@abreu-ct abreu-ct merged commit c263563 into main Jul 22, 2024
5 checks passed
@abreu-ct abreu-ct deleted the ruidias/IM-974 branch July 22, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants