Switch from Emoji based annotation to GH markdown "alerts"

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts
commercetools · Oct 23, 2024 · 16d146b · 16d146b
1 parent 003166a
commit 16d146b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/templates/argoCD-diff-pr-comment-concise.gotmpl b/templates/argoCD-diff-pr-comment-concise.gotmpl
@@ -4,7 +4,9 @@ Diff of ArgoCD applications(⚠️ concise view, full diff didn't fit GH comment
 
 
 {{if $appDiffResult.DiffError }}
-⚠️ ⚠️ **Error getting diff from ArgoCD** (`{{ $appDiffResult.ComponentPath }}`) ⚠️ ⚠️ 
+> [!CAUTION]
+> **Error getting diff from ArgoCD** (`{{ $appDiffResult.ComponentPath }}`)
+
 ``` 
 {{ $appDiffResult.DiffError }}
 
@@ -27,10 +29,9 @@ Diff of ArgoCD applications(⚠️ concise view, full diff didn't fit GH comment
 No diff 🤷
 {{- end}}
 {{if $appDiffResult.AppWasTemporarilyCreated }}
-⚠️ ⚠️ ⚠️
-This PR appears to create this new application, Telefonistka has **temporarly** created an ArgoCD app object for it just to render its manifests.
-It will not be present in ArgoCD UI for more than a few seconds and it can not be synced from the PR branch
-⚠️ ⚠️ ⚠️
+> [!NOTE]
+> This PR appears to create this new application, Telefonistka has **temporarly** created an ArgoCD app object for it just to render its manifests.
+> It will not be present in ArgoCD UI for more than a few seconds.
 {{- end}}
 
 {{- end }}

diff --git a/templates/argoCD-diff-pr-comment.gotmpl b/templates/argoCD-diff-pr-comment.gotmpl
@@ -7,10 +7,14 @@ Diff of ArgoCD applications:
 
 
 {{if $appDiffResult.DiffError }}
-⚠️ ⚠️ **Error getting diff from ArgoCD** (`{{ $appDiffResult.ComponentPath }}`) ⚠️ ⚠️
+> [!CAUTION]
+> **Error getting diff from ArgoCD** (`{{ $appDiffResult.ComponentPath }}`)
+
 Please check the App Conditions of <img src="https://argo-cd.readthedocs.io/en/stable/assets/favicon.png" width="20"/> **[{{ $appDiffResult.ArgoCdAppName }}]({{ $appDiffResult.ArgoCdAppURL }})** for more details.
 {{- if $appDiffResult.AppWasTemporarilyCreated }}
-⚠️ For investigation we kept the temporary application, please make sure to clean it up later! ⚠️
+> [!WARNING]
+> For investigation we kept the temporary application, please make sure to clean it up later!
+
 {{- end}}
 ```
 {{ $appDiffResult.DiffError }}
@@ -37,10 +41,9 @@ Please check the App Conditions of <img src="https://argo-cd.readthedocs.io/en/s
 No diff 🤷
 {{- end}}
 {{if $appDiffResult.AppWasTemporarilyCreated }}
-⚠️ ⚠️ ⚠️
-This PR appears to create this new application, Telefonistka has **temporarly** created an ArgoCD app object for it just to render its manifests.
-It will not be present in ArgoCD UI for more than a few seconds and it can not be synced from the PR branch
-⚠️ ⚠️ ⚠️
+> [!NOTE]
+> This PR appears to create this new application, Telefonistka has **temporarly** created an ArgoCD app object for it just to render its manifests.
+> It will not be present in ArgoCD UI for more than a few seconds.
 {{- end}}
 
 {{- end }}