Skip to content

Commit

Permalink
SD-838: fix panic (#33)
Browse files Browse the repository at this point in the history
* Fix potential panic

The change [1] introduced a potential panic as it is trying to log the
app name when a failure happens, but the app variable is overridden
during such a failure and is thus nil.

This results in the following panic.

    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x20ddccb]

    goroutine 367 [running]:
    internal/pkg/argocd.generateDiffOfAComponent()
	    internal/pkg/argocd/argocd.go:477
    internal/pkg/argocd.GenerateDiffOfChangedComponents()
	    internal/pkg/argocd/argocd.go:561
    internal/pkg/githubapi.HandlePREvent()
	    internal/pkg/githubapi/github.go:161
    internal/pkg/githubapi.handleEvent()
	    internal/pkg/githubapi/github.go:382
    created by internal/pkg/githubapi.ReciveWebhook
	    internal/pkg/githubapi/github.go:322

By instead using the name from the query constructed prior, the panic
should be avoided.

[1] adbd913
  • Loading branch information
hnnsgstfssn authored Oct 24, 2024
1 parent 81093e4 commit 9b32fb1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/pkg/argocd/argocd.go
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ func generateDiffOfAComponent(ctx context.Context, commentDiff bool, componentPa
app, err := ac.app.Get(ctx, &appNameQuery)
if err != nil {
componentDiffResult.DiffError = err
log.Errorf("Error getting app(HardRefresh) %s: %v", app.Name, err)
log.Errorf("Error getting app(HardRefresh) %v: %v", appNameQuery.Name, err)
return componentDiffResult
}
log.Debugf("Got ArgoCD app %s", app.Name)
Expand Down

0 comments on commit 9b32fb1

Please sign in to comment.