Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle/mitigate crash and context issues #11

Merged
merged 14 commits into from
Jun 24, 2024
Merged

Handle/mitigate crash and context issues #11

merged 14 commits into from
Jun 24, 2024

Commits on Jun 14, 2024

  1. Test new timeout values

    @Oded-B
    Oded-B committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e6aa775 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Another try at debuging context issue

    @Oded-B
    Oded-B committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    35956ee View commit details
    Browse the repository at this point in the history

  2. Ignore context cancelation for now

    @Oded-B
    Oded-B committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8ccc131 View commit details
    Browse the repository at this point in the history

  3. Test a new context (not a child)

    @Oded-B
    Oded-B committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a0c9844 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Remove calls to a function that exits the process. 

    Add conext to error messages
    @Oded-B
    Oded-B committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    afb6128 View commit details
    Browse the repository at this point in the history

  2. Re-add the context cancelation defera + some comment 

    Fix some function return issues
    @Oded-B
    Oded-B committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4c9de2a View commit details
    Browse the repository at this point in the history

  3. Update server.go

    @Oded-B
    Oded-B authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f34c9b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge remote-tracking branch 'origin/main' into test_context_canceled… 

    …_issue
    @Oded-B
    Oded-B committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    94be029 View commit details
    Browse the repository at this point in the history

  2. Add more "context"(info, like for humans) to errors

    @Oded-B
    Oded-B committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3c3e214 View commit details
    Browse the repository at this point in the history

  3. Address another err with no context issue

    @Oded-B
    Oded-B committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    863b98b View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Respond the webhook only based on payload parsing. 

    Actual Event proccessing is move to backround thread.

This require some refactoring, created ReciveWebhook and ReciveEventFile
functions to represent the different behavior in Web Server VS CLI
triggering while keeping to the GH stuff in the GH package
    @Oded-B
    Oded-B committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    43f3460 View commit details
    Browse the repository at this point in the history

  2. Change handleEvent to a private function. 

    Minor comment change
    @Oded-B
    Oded-B committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    791420c View commit details
    Browse the repository at this point in the history

  3. Cancel whole drift on context deadline

    @Oded-B
    Oded-B committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    4d55de3 View commit details
    Browse the repository at this point in the history

  4. Move error function return value to the standard position 

    Handle cases where GetContents returns nil HTTP respons (like in Context
cancellation)
    @Oded-B
    Oded-B committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    16ea028 View commit details
    Browse the repository at this point in the history